Breaking: Rename consistent-output rule to require-test-output
#150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
require-test-output
branch
from
9e4c37a to
46f9918
Compare
bmish
force-pushed
the
require-test-output
branch
from
46f9918 to
50d4b17
Compare
Changes the default rule behavior to always require a test `output` assertion. The old default behavior of `consistent` (only require `output` assertions if some tests have it) is still provided as an available option. * [As of ESLint 7](https://eslint.org/docs/user-guide/migrating-to-7.0.0#additional-validation-added-to-the-ruletester-class), the `output` property is required for test cases that provide an autofix * And even when test cases don't autofix, it's still best practice to assert that there's no autofix with `output: null`
bmish
force-pushed
the
require-test-output
branch
from
50d4b17 to
4ea8bff
Compare
|
I've reconsidered this change and I don't think it's necessary anymore since ESLint 7 now enforces that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the default rule behavior to always require a test
outputassertion. The old default behavior ofconsistent(only requireoutputassertions if some tests have it) is still provided as an available option.outputproperty is required for test cases that provide an autofixoutput: nullPart of v4 release (#120).